joemarshall commented on code in PR #37821:
URL: https://github.com/apache/arrow/pull/37821#discussion_r1402199745
##########
cpp/cmake_modules/BuildUtils.cmake:
##########
@@ -742,6 +742,14 @@ function(ADD_TEST_CASE REL_TEST_NAME)
--error-exitcode=1 ${TEST_PATH} ${ARG_TEST_ARGUMENTS}")
elseif(WIN32)
add_test(${TEST_NAME} ${TEST_PATH} ${ARG_TEST_ARGUMENTS})
+ elseif(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
+ add_test(${TEST_NAME}
+ ${BUILD_SUPPORT_DIR}/run-test.sh
+ ${CMAKE_BINARY_DIR}
+ test
+ ${CMAKE_CROSSCOMPILING_EMULATOR}
+ ${TEST_PATH}
+ ${ARG_TEST_ARGUMENTS})
Review Comment:
I see that, but don't we need the stuff in `run-test.sh`? I don't mind
skipping it, but I don't see a reason not to use it for emscripten also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
