edmondop commented on code in PR #8243:
URL: https://github.com/apache/arrow-datafusion/pull/8243#discussion_r1405193295
##########
datafusion/common/src/config.rs:
##########
@@ -524,6 +524,11 @@ config_namespace! {
/// The maximum estimated size in bytes for one input side of a
HashJoin
/// will be collected into a single partition
pub hash_join_single_partition_threshold: usize, default = 1024 * 1024
+
+ /// The default filter selectivity used by Filter Statistics
+ /// when an exact selectivity cannot be determined. Valid values are
+ /// between 0 (no selectivity) and 100 (all rows are selected).
+ pub default_filter_selectivity: u8, default = 20
Review Comment:
The two main reasons for choosing a uint are the lack of Eq trait
implementation for f32, as well as the problem that could arise when
serializing numbers that cannot be perfectly represented as f32. If you had
already made this consideration and you think f32 is still a better option, let
me know and I will proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
