alamb commented on code in PR #8243:
URL: https://github.com/apache/arrow-datafusion/pull/8243#discussion_r1412505974
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -994,4 +1014,22 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_validation_filter_selectivity() -> Result<()> {
Review Comment:
Shall we also add a test showing that changing the default selectivity
actually affects the output statistics?
I think if the selectivity got hard coded to 0.2 again, no tests would fail
🤔 Maybe we could add another unit tests here setting selectivity to `0.5` or
something and demonstrating the statistics are different
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -994,4 +1014,22 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_validation_filter_selectivity() -> Result<()> {
Review Comment:
Shall we also add a test showing that changing the default selectivity
actually affects the output statistics?
I think if the selectivity got hard coded to 0.2 again, no tests would fail
🤔 Maybe we could add another unit tests here setting selectivity to `0.5` or
something and demonstrating the statistics are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
