pitrou commented on code in PR #322:
URL: https://github.com/apache/arrow-nanoarrow/pull/322#discussion_r1406447221
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -613,6 +618,458 @@ class TestingJSONWriter {
};
};
+#if defined(NANOARROW_TESTING_WITH_NLOHMANN_JSON)
+
+/// \brief Reader for the Arrow integration testing JSON format
+class TestingJSONReader {
Review Comment:
I would recommend to only put declarations in this header file and move
implementations into a .cpp.
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -613,6 +618,458 @@ class TestingJSONWriter {
};
};
+#if defined(NANOARROW_TESTING_WITH_NLOHMANN_JSON)
+
+/// \brief Reader for the Arrow integration testing JSON format
+class TestingJSONReader {
Review Comment:
Also, since this is entirely guarded by a `#ifdef`, perhaps it should go
into separate files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
