paleolimbot commented on code in PR #322:
URL: https://github.com/apache/arrow-nanoarrow/pull/322#discussion_r1406490245
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -613,6 +618,458 @@ class TestingJSONWriter {
};
};
+#if defined(NANOARROW_TESTING_WITH_NLOHMANN_JSON)
+
+/// \brief Reader for the Arrow integration testing JSON format
+class TestingJSONReader {
Review Comment:
I removed the ifdef! It's a good point that this header is rather unwieldy
and deserves its own target at this point. I'd like to defer that change until
all the extra testing features are complete since it's a tiny bit easier to
refactor in its current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
