alamb commented on code in PR #8331:
URL: https://github.com/apache/arrow-datafusion/pull/8331#discussion_r1407902431
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -828,7 +828,8 @@ mod tests {
None,
schema.as_ref(),
);
- assert!(expr.is_err());
+ // expr is ok since boolean coercion is supported
Review Comment:
I think we lost the negative coverage here -- can. you please change the
test back to checking that this is an error?
Perhaps you could change it to
```
CASE WHEN a = 'foo' THEN timestamp(500ns) WHEN a = 'bar' THEN true END
```
As bool --> timestamp coercion isn't supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
