alamb commented on code in PR #8331:
URL: https://github.com/apache/arrow-datafusion/pull/8331#discussion_r1407902875
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -1926,3 +1926,14 @@ A true
B false
C false
D false
+
+# bool_coercion
+query BBBB
+select 1 == true, false == 0, 1.0 == true, false == 'false';
Review Comment:
👍
##########
datafusion/sqllogictest/test_files/union.slt:
##########
@@ -157,6 +157,12 @@ SELECT 1 UNION SELECT 2
1
2
+query T
Review Comment:
I like the move to a new file. Can you please make it still error so we
don't lose coverage of the error case -- perhaps with something like
```
❯ SELECT 'a' a UNION ALL SELECT interval '1 minute' a;
Error during planning: UNION Column a (type: Interval(MonthDayNano)) is not
compatible with column a (type: Utf8)
```
##########
datafusion/sqllogictest/test_files/union.slt:
##########
@@ -157,6 +157,12 @@ SELECT 1 UNION SELECT 2
1
2
+query T
Review Comment:
I like the move to a new file. Can you please make it still error so we
don't lose coverage of the error case -- perhaps with something like
```
❯ SELECT 'a' a UNION ALL SELECT interval '1 minute' a;
Error during planning: UNION Column a (type: Interval(MonthDayNano)) is not
compatible with column a (type: Utf8)
```
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -1926,3 +1926,14 @@ A true
B false
C false
D false
+
+# bool_coercion
+query BBBB
+select 1 == true, false == 0, 1.0 == true, false == 'false';
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
