jsoref commented on code in PR #38924:
URL: https://github.com/apache/arrow/pull/38924#discussion_r1408674918
##########
c_glib/test/test-array.rb:
##########
@@ -141,12 +141,12 @@ def test_no_diff
def test_diff
array = build_string_array(["Start", "Shutdown", "Reboot"])
- other_array = build_string_array(["Start", "Shutdonw", "Reboot"])
+ other_array = build_string_array(["Start", "Shutdown_", "Reboot"])
assert_equal(<<-STRING.chomp, array.diff_unified(other_array))
@@ -1, +1 @@
-"Shutdown"
-+"Shutdonw"
++"Shutdown_"
Review Comment:
This didn't work. It's doing some sorting to an array. It was my initial
correction and tests failed when I did it.
(I know it looks like I'm just fixing things randomly without testing stuff,
but I really do try to get CI to pass before I make my initial PRs.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
