kou commented on code in PR #38924:
URL: https://github.com/apache/arrow/pull/38924#discussion_r1415033694
##########
c_glib/test/test-array.rb:
##########
@@ -141,12 +141,12 @@ def test_no_diff
def test_diff
array = build_string_array(["Start", "Shutdown", "Reboot"])
- other_array = build_string_array(["Start", "Shutdonw", "Reboot"])
+ other_array = build_string_array(["Start", "Shutdown_", "Reboot"])
assert_equal(<<-STRING.chomp, array.diff_unified(other_array))
@@ -1, +1 @@
-"Shutdown"
-+"Shutdonw"
++"Shutdown_"
Review Comment:
I took a look at this test again.
We should not change this because it's a test to detect difference of two
arrays. The "Shutdonw" typo is for the difference.
Or we can use other entirely different word something like:
```diff
diff --git a/c_glib/test/test-array.rb b/c_glib/test/test-array.rb
index c03aecf17..4da641b20 100644
--- a/c_glib/test/test-array.rb
+++ b/c_glib/test/test-array.rb
@@ -141,12 +141,12 @@ class TestArray < Test::Unit::TestCase
def test_diff
array = build_string_array(["Start", "Shutdown", "Reboot"])
- other_array = build_string_array(["Start", "Shutdonw", "Reboot"])
+ other_array = build_string_array(["Start", "Running", "Reboot"])
assert_equal(<<-STRING.chomp, array.diff_unified(other_array))
@@ -1, +1 @@
-"Shutdown"
-+"Shutdonw"
++"Running"
STRING
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
