AlenkaF commented on PR #38763: URL: https://github.com/apache/arrow/pull/38763#issuecomment-1831395206
The structure already looks pretty good. I would suggest, though, to organise it in a similar way to acero docs: - index page in the `docs/source/cpp` folder https://github.com/apache/arrow/blob/main/docs/source/cpp/streaming_execution.rst this is `docs/source/cpp/gandiva.rst` currently for gandiva docs - on the index page list all the subpages with toctree directive (`.. toctree::`) - It would be good to maybe move more content from [docs/source/cpp/gandiva.rst](https://arrow.apache.org/docs/dev/cpp/gandiva.html) to subpages, save the subpages in the gandiva folder and add them to the index page toctree - keep gandiva folder as is currently in the PR - The overall flow chart from the PR (https://github.com/apache/arrow/pull/38116#issue-1931160111) could also be added to `docs/source/cpp/gandiva/external_func.rst` subpage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
