niyue commented on code in PR #38763:
URL: https://github.com/apache/arrow/pull/38763#discussion_r1409230344


##########
docs/source/cpp/gandiva_external_func.rst:
##########
@@ -0,0 +1,251 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements.  See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership.  The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License.  You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied.  See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+============================================
+Gandiva External Functions Development Guide
+============================================
+
+1. Introduction
+===============
+
+Gandiva, as an analytical expression compiler framework, extends its 
functionality through external functions. This guide is focused on helping 
developers understand, create, and integrate external functions into Gandiva. 
External functions are user-defined, third-party functions that can be used in 
Gandiva expressions.
+
+2. Overview of External Function Types in Gandiva
+=================================================
+
+Gandiva supports two primary types of external functions:
+
+* C Functions: Functions conforming to the C calling convention. Developers 
can implement functions in various languages (like C++, Rust, C, or Zig) and 
expose them as C functions for Gandiva.

Review Comment:
   Fixed



##########
docs/source/cpp/gandiva_external_func.rst:
##########
@@ -0,0 +1,251 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements.  See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership.  The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License.  You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied.  See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+============================================
+Gandiva External Functions Development Guide
+============================================
+
+1. Introduction
+===============
+
+Gandiva, as an analytical expression compiler framework, extends its 
functionality through external functions. This guide is focused on helping 
developers understand, create, and integrate external functions into Gandiva. 
External functions are user-defined, third-party functions that can be used in 
Gandiva expressions.
+
+2. Overview of External Function Types in Gandiva
+=================================================
+
+Gandiva supports two primary types of external functions:
+
+* C Functions: Functions conforming to the C calling convention. Developers 
can implement functions in various languages (like C++, Rust, C, or Zig) and 
expose them as C functions for Gandiva.
+
+* IR Functions: Functions implemented in LLVM's Intermediate Representation 
(IR). These can be written in multiple languages and then compiled into LLVM IR 
to be registered in Gandiva.

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to