ozankabak commented on code in PR #8327:
URL: https://github.com/apache/arrow-datafusion/pull/8327#discussion_r1409120277
##########
datafusion/physical-expr/src/window/nth_value.rs:
##########
@@ -162,16 +165,27 @@ impl PartitionEvaluator for NthValueEvaluator {
NthValueKind::Nth(n) => {
let n_range =
state.window_frame_range.end -
state.window_frame_range.start;
- (n_range >= (n as usize) && size >= (n as usize), false)
+ #[allow(clippy::comparison_chain)]
Review Comment:
That Clippy lint is somewhat controversial and ignored by some people (see
relevant GH issues). I actually agree that it is a bad lint and reduces
readability, that's why I surgically disabled it while reviewing.
Not important enough to revert in a follow-on, but I wanted to explain the
context around it. We haven't had a chance to sync with @mustafasrepo about it
as I am traveling, so he was unaware why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
