alamb commented on code in PR #8327:
URL: https://github.com/apache/arrow-datafusion/pull/8327#discussion_r1410554509
##########
datafusion/physical-expr/src/window/nth_value.rs:
##########
@@ -162,16 +165,27 @@ impl PartitionEvaluator for NthValueEvaluator {
NthValueKind::Nth(n) => {
let n_range =
state.window_frame_range.end -
state.window_frame_range.start;
- (n_range >= (n as usize) && size >= (n as usize), false)
+ #[allow(clippy::comparison_chain)]
Review Comment:
Yeah, in general I find some of Clippy's requirements to reduce code
readability compared to my preferred style. However, I have found just doing
what clippy says does result in a more consistent codebase so I often just do
it for the sake of not having to explain why I disabled clippy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
