zeroshade commented on code in PR #1328:
URL: https://github.com/apache/arrow-adbc/pull/1328#discussion_r1409474581
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -282,10 +282,10 @@ func (c *cnxn) getObjectsDbSchemas(ctx context.Context,
depth adbc.ObjectDepth,
conditions := make([]string, 0)
if catalog != nil && *catalog != "" {
- conditions = append(conditions, ` CATALOG_NAME LIKE
'`+*catalog+`'`)
+ conditions = append(conditions, ` CATALOG_NAME ILIKE
'`+*catalog+`'`)
}
if dbSchema != nil && *dbSchema != "" {
- conditions = append(conditions, ` SCHEMA_NAME LIKE
'`+*dbSchema+`'`)
+ conditions = append(conditions, ` SCHEMA_NAME ILIKE
'`+*dbSchema+`'`)
Review Comment:
would it be worthwhile adding tests in the Go side for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
