davidhcoe commented on code in PR #1328:
URL: https://github.com/apache/arrow-adbc/pull/1328#discussion_r1409472508
##########
csharp/test/Drivers/Snowflake/DriverTests.cs:
##########
@@ -40,10 +40,42 @@ public class DriverTests : IDisposable
readonly AdbcDatabase _database;
readonly AdbcConnection _connection;
+ public static IEnumerable<object[]> GetPatterns(string name)
+ {
+ yield return new object[] { name };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name)}%" };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name).ToLower()}%" };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name).ToUpper()}%" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name)}" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name).ToLower()}" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name).ToUpper()}" };
+ }
+
+ public static IEnumerable<object[]> CatalogNamePatternData()
+ {
+
Skip.IfNot(Utils.CanExecuteTestConfig(SnowflakeTestingUtils.SNOWFLAKE_TEST_CONFIG_VARIABLE));
Review Comment:
why would we skip here instead of just skipping the test that calls this?
##########
csharp/test/Drivers/Snowflake/DriverTests.cs:
##########
@@ -40,10 +40,42 @@ public class DriverTests : IDisposable
readonly AdbcDatabase _database;
readonly AdbcConnection _connection;
+ public static IEnumerable<object[]> GetPatterns(string name)
+ {
+ yield return new object[] { name };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name)}%" };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name).ToLower()}%" };
+ yield return new object[] {
$"{DriverTests.GetPartialNameForPatternMatch(name).ToUpper()}%" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name)}" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name).ToLower()}" };
+ yield return new object[] {
$"_{DriverTests.GetNameWithoutFirstChatacter(name).ToUpper()}" };
+ }
+
+ public static IEnumerable<object[]> CatalogNamePatternData()
+ {
+
Skip.IfNot(Utils.CanExecuteTestConfig(SnowflakeTestingUtils.SNOWFLAKE_TEST_CONFIG_VARIABLE));
Review Comment:
same with the other areas, including the SnowflakeTestingUtils class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
