spaydar commented on code in PR #8159:
URL: https://github.com/apache/arrow-datafusion/pull/8159#discussion_r1409642933
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -201,7 +214,10 @@ pub fn cast_with_options(
let expr_type = expr.data_type(input_schema)?;
if expr_type == cast_type {
Ok(expr.clone())
- } else if can_cast_types(&expr_type, &cast_type) {
+ } else if can_cast_types(&expr_type, &cast_type)
Review Comment:
Yes, if this can be pushed down to the arrow crate, the complexity in
datafusion would be reduced. I wasn't sure if doing so was appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
