spaydar commented on code in PR #8159:
URL: https://github.com/apache/arrow-datafusion/pull/8159#discussion_r1410005605
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -201,7 +214,10 @@ pub fn cast_with_options(
let expr_type = expr.data_type(input_schema)?;
if expr_type == cast_type {
Ok(expr.clone())
- } else if can_cast_types(&expr_type, &cast_type) {
+ } else if can_cast_types(&expr_type, &cast_type)
Review Comment:
`can_cast_types` was returning false in my testing yesterday for `Float64`
-> `Timestamp(Nanosecond, None)`, seemingly because the line you linked has not
been released yet. The type check was changed from `is_integer` to `is_numeric`
[only a few days
ago](https://github.com/apache/arrow-rs/commit/435b53ded3710216e32ad3f82ae4910f50954e06#diff-50ca33c0aee08395003926d3f7c2d7ee6d90199dea0f2642856cfac201e27a68L226-R225),
whereas the last arrow-rs release was 3 weeks ago.
Should we wait until the next arrow-rs release so I can leverage this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
