alamb opened a new pull request, #8365:
URL: https://github.com/apache/arrow-datafusion/pull/8365

   ## Which issue does this PR close?
   
   Related to / follow on to  
https://github.com/apache/arrow-datafusion/pull/8258  from @2010YOUY01 
   
   ## Rationale for this change
   
   While integrating https://github.com/apache/arrow-datafusion/pull/8258 into 
our downstream system, I found creating a `BuildInScalarFunction` to be quite 
awkward as it had a seemingly duplicated name field. I thought the name field 
was to handle aliases or something, but it turns out I could remove it easily. 
   
   ## What changes are included in this PR?
   
   Basically change the `ScalarFunctionDefinition::BuiltIn` to match the others
   
   ```rust
       BuiltIn {
           fun: built_in_function::BuiltinScalarFunction,
           name: Arc<str>,
       },
   ```
   
   to 
   
   ```rust
       BuiltIn(BuiltinScalarFunction),
   ```
   ## Are these changes tested?
   Covered by existing tests
   
   ## Are there any user-facing changes?
   
   While this is technically an API change the API hasn't been released so it 
isn't an additional breaking API change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to