alamb commented on code in PR #8365:
URL: https://github.com/apache/arrow-datafusion/pull/8365#discussion_r1409794538
##########
datafusion/expr/src/expr.rs:
##########
@@ -342,10 +342,7 @@ pub enum ScalarFunctionDefinition {
/// Resolved to a `BuiltinScalarFunction`
/// There is plan to migrate `BuiltinScalarFunction` to UDF-based
implementation (issue#8045)
/// This variant is planned to be removed in long term
- BuiltIn {
- fun: built_in_function::BuiltinScalarFunction,
- name: Arc<str>,
- },
+ BuiltIn(BuiltinScalarFunction),
Review Comment:
This is the core change here -- don't keep another string around, but just
use the function on demand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
