jayzhan211 commented on code in PR #8308:
URL: https://github.com/apache/arrow-datafusion/pull/8308#discussion_r1411421025
##########
datafusion/physical-expr/src/window/lead_lag.rs:
##########
@@ -238,9 +238,8 @@ fn get_default_value(
) -> Result<ScalarValue> {
if let Some(default_value) = default_value {
let default_value_type = default_value.data_type();
- if can_coerce_from(dtype, &default_value_type)
- || (dtype.is_integer() && default_value_type.is_integer())
- {
+
+ if comparison_coercion(&default_value_type, dtype).is_some() {
Review Comment:
Code from your previous commit
```rust
if can_coerce_from(dtype, &default_value_type)
|| (dtype.is_integer() && default_value_type.is_integer())
```
Comment similar to
// We only check coercion between integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
