jayzhan211 commented on code in PR #8308:
URL: https://github.com/apache/arrow-datafusion/pull/8308#discussion_r1412113005
##########
datafusion/physical-expr/src/window/lead_lag.rs:
##########
@@ -238,9 +238,8 @@ fn get_default_value(
) -> Result<ScalarValue> {
if let Some(default_value) = default_value {
let default_value_type = default_value.data_type();
- if can_coerce_from(dtype, &default_value_type)
- || (dtype.is_integer() && default_value_type.is_integer())
- {
+
+ if comparison_coercion(&default_value_type, dtype).is_some() {
Review Comment:
I was suggesting `comparison_coercion` with comment.
But, I rethink about it again, now I think
```rust
if can_coerce_from(dtype, &default_value_type)
|| (dtype.is_integer() && default_value_type.is_integer())
```
is better for here.
btw, i dont think your comment `// We explicitely allow a lossy conversion
between signed and unsigned integers` is correct 🤔
##########
datafusion/physical-expr/src/window/lead_lag.rs:
##########
@@ -238,9 +238,8 @@ fn get_default_value(
) -> Result<ScalarValue> {
if let Some(default_value) = default_value {
let default_value_type = default_value.data_type();
- if can_coerce_from(dtype, &default_value_type)
- || (dtype.is_integer() && default_value_type.is_integer())
- {
+
+ if comparison_coercion(&default_value_type, dtype).is_some() {
Review Comment:
I was suggesting `comparison_coercion` with comment.
But, I rethink about it again, now I think
```rust
if can_coerce_from(dtype, &default_value_type)
|| (dtype.is_integer() && default_value_type.is_integer())
```
is better for here.
btw, i dont think your comment `// We explicitely allow a lossy conversion
between signed and unsigned integers` is correct 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
