Asura7969 commented on code in PR #8384:
URL: https://github.com/apache/arrow-datafusion/pull/8384#discussion_r1411504922
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -981,41 +981,17 @@ impl LogicalPlan {
/// // Fill in the parameter $1 with a literal 3
/// let plan = plan.with_param_values(vec![
/// ScalarValue::from(3i32) // value at index 0 --> $1
- /// ]).unwrap();
+ /// ].into()).unwrap();
///
/// assert_eq!("Filter: t1.id = Int32(3)\
/// \n TableScan: t1",
/// plan.display_indent().to_string()
/// );
/// ```
- pub fn with_param_values(
- self,
- param_values: Vec<ScalarValue>,
- ) -> Result<LogicalPlan> {
+ pub fn with_param_values(self, param_values: ParamValues) ->
Result<LogicalPlan> {
match self {
LogicalPlan::Prepare(prepare_lp) => {
- // Verify if the number of params matches the number of values
Review Comment:
move to ParamValues(`verify` method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
