Asura7969 commented on code in PR #8384:
URL: https://github.com/apache/arrow-datafusion/pull/8384#discussion_r1411505749
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1236,36 +1212,15 @@ impl LogicalPlan {
/// corresponding values provided in the params_values
fn replace_placeholders_with_values(
expr: Expr,
- param_values: &[ScalarValue],
+ param_values: &ParamValues,
) -> Result<Expr> {
expr.transform(&|expr| {
match &expr {
Expr::Placeholder(Placeholder { id, data_type }) => {
- if id.is_empty() || id == "$0" {
Review Comment:
move to ParamValues(`get_placeholders_with_values` method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
