edmondop commented on code in PR #8382:
URL: https://github.com/apache/arrow-datafusion/pull/8382#discussion_r1411573427
##########
datafusion/expr/src/window_function.rs:
##########
@@ -32,7 +32,7 @@ use strum_macros::EnumIter;
/// WindowFunction
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub enum WindowFunction {
+pub enum WindowFunctionDefinition {
Review Comment:
If I understood correctly, this
[2f4ce8368ae5003648919bb1201f08a2dbe23d5f](https://github.com/apache/arrow-datafusion/pull/8382/commits/2f4ce8368ae5003648919bb1201f08a2dbe23d5f)
should be it. There are two commits after this, one to merge a change in
expr.rs in the main branch and the following one to reformat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
