haohuaijin commented on code in PR #8382:
URL: https://github.com/apache/arrow-datafusion/pull/8382#discussion_r1411837508
##########
datafusion/expr/src/window_function.rs:
##########
@@ -32,7 +32,7 @@ use strum_macros::EnumIter;
/// WindowFunction
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub enum WindowFunction {
+pub enum WindowFunctionDefinition {
Review Comment:
@edmondop sorry for make you misunderstood, I mean we only move the code
related to `WindowFunctionDefinition`
https://github.com/apache/arrow-datafusion/blob/e19c669855baa8b78ff86755803944d2ddf65536/datafusion/expr/src/window_function.rs#L34-L44
https://github.com/apache/arrow-datafusion/blob/e19c669855baa8b78ff86755803944d2ddf65536/datafusion/expr/src/window_function.rs#L69-L78
https://github.com/apache/arrow-datafusion/blob/e19c669855baa8b78ff86755803944d2ddf65536/datafusion/expr/src/window_function.rs#L166-L178
https://github.com/apache/arrow-datafusion/blob/e19c669855baa8b78ff86755803944d2ddf65536/datafusion/expr/src/window_function.rs#L227-L237
into `datafusion/expr/src/expr.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
