CurtHagenlocher commented on code in PR #38046:
URL: https://github.com/apache/arrow/pull/38046#discussion_r1412915816
##########
csharp/src/Apache.Arrow/Ipc/DictionaryMemo.cs:
##########
@@ -24,13 +24,13 @@ class DictionaryMemo
{
private readonly Dictionary<long, IArrowArray> _idToDictionary;
private readonly Dictionary<long, IArrowType> _idToValueType;
- private readonly Dictionary<Field, long> _fieldToId;
+ private readonly Dictionary<string, long> _fieldToId;
Review Comment:
I don't think this change is technically correct because it ignores the fact
that e.g. two nested structs could have dictionary-encoded fields with the same
name and these would now collide. Obviously the existing implementation isn't
great either in that it implicitly relies on reference equality (which I assume
is what causes problems for Flight). I don't have any immediate suggestions
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
