CurtHagenlocher commented on code in PR #38046:
URL: https://github.com/apache/arrow/pull/38046#discussion_r1423387030
##########
csharp/src/Apache.Arrow/Ipc/DictionaryMemo.cs:
##########
@@ -24,13 +24,13 @@ class DictionaryMemo
{
private readonly Dictionary<long, IArrowArray> _idToDictionary;
private readonly Dictionary<long, IArrowType> _idToValueType;
- private readonly Dictionary<Field, long> _fieldToId;
+ private readonly Dictionary<string, long> _fieldToId;
Review Comment:
You can check out my attempt at an implementation at
https://github.com/CurtHagenlocher/arrow/tree/dev/curth/FlightDictionaries. It
changes the write side of flight server so that the same schema is used to
collect the dictionaries for each batch. This continues to let reference
equality work for calculating dictionary IDs. I also refactored the "Post"
changes to be (what I think is) a little cleaner.
Disclaimer: I am not very familiar with the Flight code or protocol, but
your changed tests are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
