mapleFU commented on code in PR #38959:
URL: https://github.com/apache/arrow/pull/38959#discussion_r1413140185
##########
cpp/src/parquet/encoding.h:
##########
@@ -233,7 +233,7 @@ class DictEncoder : virtual public TypedEncoder<DType> {
/// \brief EXPERIMENTAL: Append dictionary indices into the encoder. It is
/// assumed (without any boundschecking) that the indices reference
- /// pre-existing dictionary values
+ /// preexisting dictionary values
Review Comment:
Actually I'm not a native english speaker, so I wonder what's the
differences between `pre-existing` and `preexisting`?
##########
cpp/src/parquet/statistics.h:
##########
@@ -205,7 +205,7 @@ class PARQUET_EXPORT Statistics {
::arrow::MemoryPool* pool = ::arrow::default_memory_pool());
/// \brief Create a new statistics instance given a column schema
- /// definition and pre-existing state
+ /// definition and preexisting state
Review Comment:
ditto
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -425,7 +425,7 @@ TEST_F(TestAllTypesPlain, TestBatchRead) {
ASSERT_FALSE(col->HasNext());
}
-TEST_F(TestAllTypesPlain, RowGroupColumnBoundchecking) {
+TEST_F(TestAllTypesPlain, RowGroupColumnBoundschecking) {
Review Comment:
```suggestion
TEST_F(TestAllTypesPlain, RowGroupColumnBoundsChecking) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
