jsoref commented on code in PR #38959:
URL: https://github.com/apache/arrow/pull/38959#discussion_r1413813570
##########
cpp/src/parquet/encoding.h:
##########
@@ -233,7 +233,7 @@ class DictEncoder : virtual public TypedEncoder<DType> {
/// \brief EXPERIMENTAL: Append dictionary indices into the encoder. It is
/// assumed (without any boundschecking) that the indices reference
- /// pre-existing dictionary values
+ /// preexisting dictionary values
Review Comment:
since 1970, the unhyphenated version has become dominant:
https://books.google.com/ngrams/graph?content=preexisting%2Cpre-existing&year_start=1800&year_end=2019&corpus=en-US-2019&smoothing=3
-- it's also used in various apache projects. I think it's a reasonable
improvement, so if you aren't strenuously pushing against it, let's include the
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
