kylebarron commented on code in PR #35780:
URL: https://github.com/apache/arrow/pull/35780#discussion_r1413211156
##########
js/src/enum.ts:
##########
@@ -137,8 +137,7 @@ export enum MessageHeader {
* nested type consisting of other data types, or another data type (e.g. a
* timestamp encoded as an int64).
*
- * **Note**: Only enum values 0-18 (NONE through Duration) are written to an
Arrow
- * IPC payload.
+ * **Note**: Only positive enum values are written to an Arrow IPC payload.
Review Comment:
```suggestion
* **Note**: Only non-negative enum values are written to an Arrow IPC
payload.
```
Maybe this is pedantic; does `0` get written to IPC as the original comment
suggested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
