felipecrv commented on code in PR #39009:
URL: https://github.com/apache/arrow/pull/39009#discussion_r1414717355
##########
cpp/src/arrow/filesystem/path_util.cc:
##########
@@ -72,15 +72,12 @@ std::string SliceAbstractPath(const std::string& s, int
offset, int length, char
return "";
}
std::vector<std::string> components = SplitAbstractPath(s, sep);
- std::stringstream combined;
if (offset >= static_cast<int>(components.size())) {
return "";
}
- int end = offset + length;
- if (end > static_cast<int>(components.size())) {
- end = static_cast<int>(components.size());
- }
- for (int i = offset; i < end; i++) {
+ const size_t end = std::min(static_cast<size_t>(offset) + length,
components.size());
Review Comment:
Fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
