felipecrv commented on code in PR #39009:
URL: https://github.com/apache/arrow/pull/39009#discussion_r1414718868
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -1103,7 +1330,12 @@ Result<FileInfo> AzureFileSystem::GetFileInfo(const
std::string& path) {
}
Result<FileInfoVector> AzureFileSystem::GetFileInfo(const FileSelector&
select) {
- return Status::NotImplemented("The Azure FileSystem is not fully
implemented");
+ Azure::Core::Context context;
+ Azure::Nullable<int32_t> page_size_hint; // unspecified
+ FileInfoVector results;
+ RETURN_NOT_OK(
+ impl_->GetFileInfoWithSelector(context, page_size_hint, select,
&results));
+ return std::move(results);
Review Comment:
This is because I want to move the `results` into the `Result<T>` that is
being created.
It's equivalent to this:
```cpp
Result<FileInfoVector> result{std::move(results)};
return result;
```
I will change the line to `return {std::move(results)};` to clarify what is
going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
