alamb commented on a change in pull request #9263:
URL: https://github.com/apache/arrow/pull/9263#discussion_r560339129
##########
File path: rust/arrow/src/util/display.rs
##########
@@ -44,6 +44,57 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_date {
+ ($array_type:ty, $column: ident, $row: ident) => {{
+ let array = $column.as_any().downcast_ref::<$array_type>().unwrap();
+
+ let s = if array.is_null($row) {
+ "".to_string()
Review comment:
I think there are tradeoffs between using empty string or some sentinel
(`"NULL"`) for display; I don't have a super strong preference though I do
think the behavior should be consistent across types
This PR follows the same convention as the rest of this module and uses ""
for NULL values:
https://github.com/apache/arrow/pull/9263/files#diff-821be3a8a9239cdd12ab2b3c979e174f7b936aa6bfad4b9bc76489b9923cf747R38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
