Dandandan commented on a change in pull request #9263:
URL: https://github.com/apache/arrow/pull/9263#discussion_r560364731
##########
File path: rust/arrow/src/util/display.rs
##########
@@ -44,6 +44,57 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_date {
+ ($array_type:ty, $column: ident, $row: ident) => {{
+ let array = $column.as_any().downcast_ref::<$array_type>().unwrap();
+
+ let s = if array.is_null($row) {
+ "".to_string()
Review comment:
Makes sense to me. I think the "problem" would be when displaying
strings, as the empty string is displayed the same way as null, but I agree it
is better to keep it consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
