pitrou commented on code in PR #330:
URL: https://github.com/apache/arrow-nanoarrow/pull/330#discussion_r1417075948
##########
src/nanoarrow/nanoarrow_testing_test.cc:
##########
@@ -170,12 +171,13 @@ TEST(NanoarrowTestingTest,
NanoarrowTestingTestColumnFloat) {
return ArrowSchemaInitFromType(schema, NANOARROW_TYPE_FLOAT);
},
[](ArrowArray* array) {
+ NANOARROW_RETURN_NOT_OK(ArrowArrayAppendNull(array, 1));
NANOARROW_RETURN_NOT_OK(ArrowArrayAppendDouble(array, 0.1234));
NANOARROW_RETURN_NOT_OK(ArrowArrayAppendDouble(array, 1.2345));
return NANOARROW_OK;
},
&WriteColumnJSON,
- R"({"name": null, "count": 2, "VALIDITY": [1, 1], "DATA": [0.123,
1.235]})");
+ R"({"name": null, "count": 3, "VALIDITY": [0, 1, 1], "DATA": [0.000,
0.123, 1.235]})");
Review Comment:
The fixed output precision is amusing. Hopefully it's not a problem for
integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
