pitrou commented on code in PR #330:
URL: https://github.com/apache/arrow-nanoarrow/pull/330#discussion_r1417082982
##########
src/nanoarrow/nanoarrow_testing_test.cc:
##########
@@ -409,9 +433,8 @@ TEST(NanoarrowTestingTest, NanoarrowTestingTestFieldNested)
{
},
[](ArrowArray* array) { return NANOARROW_OK; }, &WriteFieldJSON,
R"({"name": null, "nullable": true, "type": {"name": "struct"},
"children": [)"
- R"({"name": null, "nullable": true, "type": {"name": "null"},
"children": [], "metadata": null}, )"
- R"({"name": null, "nullable": true, "type": {"name": "utf8"},
"children": [], "metadata": null}], )"
- R"("metadata": null})");
+ R"({"name": null, "nullable": true, "type": {"name": "null"},
"children": []}, )"
+ R"({"name": null, "nullable": true, "type": {"name": "utf8"},
"children": []}]})");
Review Comment:
Are there tests for struct fields with non-empty metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
