jayzhan211 commented on code in PR #8439:
URL: https://github.com/apache/arrow-datafusion/pull/8439#discussion_r1417465069
##########
datafusion/physical-expr/src/aggregate/array_agg_ordered.rs:
##########
@@ -329,6 +319,8 @@ impl OrderSensitiveArrayAggAccumulator {
.collect();
let struct_type = DataType::Struct(Fields::from(fields));
+ // TODO: Since ScalarValue::Struct is not yet includes StructArray,
+ // so we need to convert it to ListArray for ScalarValue::List
let arr = ScalarValue::new_list(&orderings, &struct_type);
Ok(ScalarValue::List(arr))
Review Comment:
`agg_orderings` is the return value of `evaluate_orderings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
