jayzhan211 commented on code in PR #8439:
URL: https://github.com/apache/arrow-datafusion/pull/8439#discussion_r1418188099
##########
datafusion/physical-expr/src/aggregate/array_agg_ordered.rs:
##########
@@ -232,10 +232,21 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
}
let orderings =
ScalarValue::convert_array_to_scalar_vec(agg_orderings)?;
- // Ordering requirement expression values for each entry in the
ARRAY_AGG list
- let other_ordering_values =
self.convert_array_agg_to_orderings(orderings)?;
- for v in other_ordering_values.into_iter() {
- partition_ordering_values.push(v);
+
+ for partition_ordering_rows in orderings.into_iter() {
Review Comment:
I think `convert_array_agg_to_orderings` is doing quite specific thing, so
remove the function and do things here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
