lidavidm commented on code in PR #1345:
URL: https://github.com/apache/arrow-adbc/pull/1345#discussion_r1417839604
##########
.github/CODEOWNERS:
##########
@@ -27,7 +27,7 @@ adbc.h @lidavidm
## Implementations
/c/ @lidavidm
-/csharp/ @lidavidm
Review Comment:
Unfortunately, only committers can be listed here.
##########
csharp/Directory.Build.props:
##########
@@ -29,7 +29,7 @@
<Product>Apache Arrow ADBC library</Product>
<Copyright>Copyright 2022-2023 The Apache Software Foundation</Copyright>
<Company>The Apache Software Foundation</Company>
- <Version>0.5.0</Version>
+ <Version>0.8.0</Version>
Review Comment:
We need to add this to the post-release script that bumps versions.
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: 2
+updates:
+ - package-ecosystem: "github-actions"
+ directory: "/"
+ schedule:
+ interval: "weekly"
+ commit-message:
+ prefix: "MINOR: [CI] "
+ - package-ecosystem: "nuget"
+ directory: "/csharp/"
+ schedule:
+ interval: "weekly"
+ commit-message:
+ prefix: "MINOR: [C#] "
Review Comment:
```suggestion
prefix: "chore(csharp): "
```
##########
csharp/scripts/Build-All.ps1:
##########
Review Comment:
Where is this used?
##########
csharp/src/Apache.Arrow.Adbc/readme.md:
##########
Review Comment:
nit: README.md for consistency?
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: 2
+updates:
+ - package-ecosystem: "github-actions"
+ directory: "/"
+ schedule:
+ interval: "weekly"
+ commit-message:
+ prefix: "MINOR: [CI] "
Review Comment:
```suggestion
prefix: "chore: "
```
?
##########
csharp/scripts/Build-All.ps1:
##########
Review Comment:
Also, other similar scripts have gone in ci/scripts (plus, there's already
one there...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
