lidavidm commented on code in PR #1345: URL: https://github.com/apache/arrow-adbc/pull/1345#discussion_r1420750789
########## ci/scripts/csharp_build_pack_test.ps1: ########## Review Comment: The existing bash scripts separate build/pack and do not have test. Can we be consistent with the powershell and bash setup? ########## csharp/src/Drivers/Interop/Snowflake/Build-SnowflakeDriver.ps1: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Write-Host "Building the Snowflake ADBC Go driver" + +$location = Get-Location + +$file = "libadbc_driver_snowflake.dll" + +cd ..\..\..\..\..\go\adbc\pkg + +if(Test-Path $file) +{ + #because each framework build will run the script, avoid building it each time Review Comment: so this is hooked into the build process somehow? ########## csharp/src/Drivers/Interop/Snowflake/Build-SnowflakeDriver.ps1: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Write-Host "Building the Snowflake ADBC Go driver" + +$location = Get-Location + +$file = "libadbc_driver_snowflake.dll" + +cd ..\..\..\..\..\go\adbc\pkg + +if(Test-Path $file) +{ + #because each framework build will run the script, avoid building it each time Review Comment: also,we already have a makefile for this; I'd rather we not duplicate the build config unless there is very good reason to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
