waynexia commented on code in PR #8463:
URL: https://github.com/apache/arrow-datafusion/pull/8463#discussion_r1419917646
##########
datafusion/expr/src/signature.rs:
##########
@@ -95,6 +95,8 @@ pub enum TypeSignature {
VariadicEqual,
/// One or more arguments with arbitrary types
VariadicAny,
+ /// arbitrary number of arguments out of a possibly different but limited
set of valid types
+ VariadicLimited(Vec<DataType>),
Review Comment:
Now we have `Variadic`, `VariadicLimited` and `VariadicEqual`,
`VariadicAny`. Their behaviors are similar, and I'm wondering how we can better
reflect their difference in naming.
The tail `Limited` also applies to `Variadic`. So `Variadic` is in actual
"variadic" + "equal" + "limited", and the new one is "variadic" + "any" +
"limited". How about changing `Variadic` to `VariadicLimitedEqual` and naming
the new one `VariadicLimitedAny`? But they are a bit verbose, is there any
other options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
