alamb commented on code in PR #8463: URL: https://github.com/apache/arrow-datafusion/pull/8463#discussion_r1420804799
########## dev/changelog/33.0.0.md: ########## @@ -17,9 +17,9 @@ under the License. --> Review Comment: I don't understand why this changelog file was modified in this PR. Perhaps it was a mistake 🤔 It seems to be some part of a change added in https://github.com/apache/arrow-datafusion/pull/8144 ########## datafusion/expr/src/built_in_function.rs: ########## @@ -890,7 +890,7 @@ impl BuiltinScalarFunction { // 0 or more arguments of arbitrary type Signature::one_of(vec![VariadicAny, Any(0)], self.volatility()) } - BuiltinScalarFunction::Struct => Signature::variadic( + BuiltinScalarFunction::Struct => Signature::variadic_limited( Review Comment: What do you think about using `Signature::variadic_any`? That I think would pass along the argument types directly (not try to coerce them) ########## dev/changelog/33.0.0.md: ########## @@ -17,9 +17,9 @@ under the License. --> Review Comment: I don't understand why this changelog file was modified in this PR. Perhaps it was a mistake 🤔 It seems to be some part of a change added in https://github.com/apache/arrow-datafusion/pull/8144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
