jayzhan211 commented on code in PR #8317:
URL: https://github.com/apache/arrow-datafusion/pull/8317#discussion_r1421179330


##########
datafusion/expr/src/signature.rs:
##########
@@ -95,6 +95,8 @@ pub enum TypeSignature {
     VariadicEqual,
     /// One or more arguments with arbitrary types
     VariadicAny,
+    /// A function such as `make_array` should be coerced to the same type
+    VariadicCoerced,

Review Comment:
   I just noticed that `VariadicEqual` is not used in any function. Maybe we 
can just keep one.
   
   I thought Equal is the one that don't care about coercion. All the type 
should be equal like (i32, i32, i32).
   Coerced is the one that ensuring the final coerced type is the same (all of 
the type coercible to the same one), like (i32, i64) -> i64.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to