jayzhan211 commented on code in PR #8317: URL: https://github.com/apache/arrow-datafusion/pull/8317#discussion_r1421205568
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -1092,18 +1090,27 @@ select list_sort(make_array(1, 3, null, 5, NULL, -5)), list_sort(make_array(1, 3 ## array_append (aliases: `list_append`, `array_push_back`, `list_push_back`) -# TODO: array_append with NULLs -# array_append scalar function #1 -# query ? -# select array_append(make_array(), 4); -# ---- -# [4] +# array_append with NULLs -# array_append scalar function #2 -# query ?? -# select array_append(make_array(), make_array()), array_append(make_array(), make_array(4)); -# ---- -# [[]] [[4]] +query ??????? +select + array_append(null, 1), Review Comment: Clickhouse and Duckdb has the same output for `array_append(make_array(null, null), 1) ` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
