joroKr21 opened a new pull request, #8511: URL: https://github.com/apache/arrow-datafusion/pull/8511
Use `logical_nulls` when the array data type is `Null`. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #8509. ## Rationale for this change The semantics of `NullArray` in Arrow are confusing: https://github.com/apache/arrow-rs/pull/4838 So we have to handle the `Null` data type in a special way. ## What changes are included in this PR? Patches in count and count distinct accumulators to handle the `Null` data type or use `logical_nulls` when appropriate. ## Are these changes tested? Yes, added SQL tests. ## Are there any user-facing changes? Yes, count and count distinct now behave consistently wrt `null` regardless of the data type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
