joroKr21 commented on code in PR #8511:
URL: https://github.com/apache/arrow-datafusion/pull/8511#discussion_r1425000654
##########
datafusion/physical-expr/src/aggregate/count.rs:
##########
@@ -198,16 +198,18 @@ fn null_count_for_multiple_cols(values: &[ArrayRef]) ->
usize {
if values.len() > 1 {
let result_bool_buf: Option<BooleanBuffer> = values
.iter()
- .map(|a| a.nulls())
+ .map(|a| a.logical_nulls())
Review Comment:
I'm not sure how I would implement this outside of the `Array` trait while
ensuring that all cases are covered. Originally I had some branching logic
based on the datatype but removed it after the discussion here:
https://github.com/apache/arrow-datafusion/pull/8511#discussion_r1423733822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
