pitrou commented on code in PR #334:
URL: https://github.com/apache/arrow-nanoarrow/pull/334#discussion_r1423986892
##########
extensions/nanoarrow_ipc/src/nanoarrow/nanoarrow_ipc_files_test.cc:
##########
@@ -133,26 +227,18 @@ class TestFile {
GTEST_FAIL() << MakeError(NANOARROW_OK, "");
}
- // Read the same data with Arrow C++.
- auto content_copy_wrapped =
- Buffer::Wrap<uint8_t>(content_copy->data, content_copy->size_bytes);
- auto buffer_reader =
std::make_shared<io::BufferReader>(content_copy_wrapped);
-
- // Support Arrow 9.0.0 for Fedora and Centos7 images
-#if ARROW_VERSION_MAJOR >= 10
- auto maybe_input_stream =
- io::RandomAccessFile::GetStream(buffer_reader, 0,
content_copy_wrapped->size());
+ // Read the same file with Arrow C++. Use the in-memory version to avoid
+ // requiring Arrow C++ with filesystem.
Review Comment:
You don't need the filesystem layer to use `arrow::io::ReadableFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
