felipecrv commented on PR #334: URL: https://github.com/apache/arrow-nanoarrow/pull/334#issuecomment-1852417552
You can convert the unique_ptr to shared_ptr implicitly by std::move’ing it. The proliferation of shared_ptr everywhere is so unfortunate. On Tue, 12 Dec 2023 at 13:44 Dewey Dunnington ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In extensions/nanoarrow_ipc/src/nanoarrow/nanoarrow_ipc_files_test.cc > <https://github.com/apache/arrow-nanoarrow/pull/334#discussion_r1424291404> > : > > > > - struct ArrowIpcInputStream input; > + // Create an arrow::io::InputStream wrapper around an ArrowBuffer > + static arrow::Result<std::shared_ptr<io::InputStream>> BufferInputStream( > > I tried this, but the functions that need an InputStream to which the > result is passed seem to require a std::shared_ptr<InputStream>! > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-nanoarrow/pull/334#discussion_r1424291404>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABSXM7FX7D5TUHU5X62SWLYJCCVDAVCNFSM6AAAAABAQAT3N6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZXHE4DQOJVGM> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
