Veeupup commented on code in PR #8496:
URL: https://github.com/apache/arrow-datafusion/pull/8496#discussion_r1424149683
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -87,9 +87,11 @@ fn signature(lhs: &DataType, op: &Operator, rhs: &DataType)
-> Result<Signature>
}
And | Or => if matches!((lhs, rhs), (Boolean | Null, Boolean | Null)) {
// Logical binary boolean operators can only be evaluated for
- // boolean or null arguments.
+ // boolean or null arguments.
Ok(Signature::uniform(DataType::Boolean))
- } else {
+ } else if matches!((lhs, rhs), (List(_), List(_))) {
+ Ok(Signature::uniform(lhs.clone()))
Review Comment:
I reuse `array_coercion` to resolve the data type~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
