jayzhan211 commented on code in PR #8496:
URL: https://github.com/apache/arrow-datafusion/pull/8496#discussion_r1424679578
##########
datafusion/sql/src/expr/binary_op.rs:
##########
@@ -47,6 +47,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
BinaryOperator::PGBitwiseShiftRight =>
Ok(Operator::BitwiseShiftRight),
BinaryOperator::PGBitwiseShiftLeft =>
Ok(Operator::BitwiseShiftLeft),
BinaryOperator::StringConcat => Ok(Operator::StringConcat),
+ BinaryOperator::PGOverlap => Ok(Operator::And),
Review Comment:
We should only have `list && list` for array intersect not `AND` to be
consistent with Duckdb.
I see, BinaryOperator::PGOverlap and BinaryOperator::AND are both converted
to Opeator::AND, this is what make `&&` and `AND` am alias.
But it seems to me that BinaryOperator::PGOverlap (`&&`) to Operator::AND
is more straightforward, maybe avoid BinaryOperator::AND (`AND`) to
Operator::AND is the one to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
